Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-123336 / 24.04 / WebUI tooltips are malfunctioning in chrome #8527

Merged
merged 5 commits into from
Aug 11, 2023

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented Aug 3, 2023

Testing:
See ticket description (I tested on Bluefin as well, problem occurs there as well, it's browser update problem)

and 👇

Check help tooltips
Screenshot 2023-08-03 at 16 55 07

(as well added hide on scroll feature, I think it's useful)

@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner August 3, 2023 13:56
@AlexKarpov98 AlexKarpov98 self-assigned this Aug 3, 2023
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team August 3, 2023 13:56
@bugclerk bugclerk changed the title NAS-123336: WebUI tooltips are malfunctioning in chrome NAS-123336 / 24.04 / WebUI tooltips are malfunctioning in chrome Aug 3, 2023
@bugclerk
Copy link
Contributor

bugclerk commented Aug 3, 2023

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #8527 (cc8a6f0) into master (229cff2) will decrease coverage by 0.08%.
Report is 15 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #8527      +/-   ##
==========================================
- Coverage   58.12%   58.04%   -0.08%     
==========================================
  Files        1227     1230       +3     
  Lines       46904    47049     +145     
  Branches     5759     5777      +18     
==========================================
+ Hits        27261    27311      +50     
- Misses      19643    19738      +95     
Files Changed Coverage Δ
src/app/app.module.ts 0.00% <ø> (ø)
...ms/components/ix-slide-in/ix-slide-in.component.ts 86.79% <100.00%> (+0.79%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now tooltips don't work for me in Chrome. They also flash in form when it is being open.

2023-08-07.15.10.37.mov

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in 3 browsers, with or without cache.
Same result – I cannot press on the tooltip icon.
In fact, I cannot press the underlying field in some places too. It's like the tooltip is open and blocking the access.

2023-08-08.10.14.59.mov

@AlexKarpov98
Copy link
Contributor Author

AlexKarpov98 commented Aug 8, 2023

@undsoft
Check it out now.
It's working fine for me [again].
Tested:

  • Chrome Version 115.0.5790.170 (Official Build) (arm64)
  • Safari 16.2
Screen.Recording.2023-08-08.at.13.37.13.mov

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kapture.2023-08-08.at.18.43.15.mp4

Chrome 115.0.5790.114 and 115.0.5790.170 shows the same behavior

@AlexKarpov98
Copy link
Contributor Author

@undsoft @denysbutenko - now it will work! Please give it a try

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kapture.2023-08-08.at.19.44.39.mp4

Tooltips are back, and an extra scrollbar has appeared.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to be working correctly for me.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltips flash for half a second when you open the form

Screen.Recording.2023-08-08.at.11.46.07.PM.mov

@AlexKarpov98
Copy link
Contributor Author

@RehanY147 - please try with fresh yarn install
i can't reproduce your defect.

@denysbutenko - please try it now [with Shell popper].

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great for me.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) August 9, 2023 06:07
@AlexKarpov98
Copy link
Contributor Author

@RehanY147 - waiting for you only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants