Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method for downloading streaming files on the backend to prevent need to open a new tab #2951

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Add method for downloading streaming files on the backend to prevent need to open a new tab #2951

merged 3 commits into from
Oct 24, 2019

Conversation

erincodepirate
Copy link
Contributor

NAS-103588

dkmullen
dkmullen reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@dkmullen dkmullen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this (screenshot) should be inside the storage.streamDownloadFile block? I had an error the first time I saved the debug on this branch, but the job ran anyway, then failed. Otherwise, works great.

image

dkmullen
dkmullen approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@dkmullen dkmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erincodepirate erincodepirate merged commit 1d8b27a into master Oct 24, 2019
@erincodepirate erincodepirate deleted the NAS-103588 branch October 24, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkmullen dkmullen dkmullen approved these changes

@lola27 lola27 Awaiting requested review from lola27

@aervin aervin Awaiting requested review from aervin

@dszidi dszidi Awaiting requested review from dszidi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erincodepirate @dkmullen