NAS-132334 / 25.04 / Add environment variables to containers #11015
+363
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11015 +/- ##
==========================================
- Coverage 82.12% 82.09% -0.03%
==========================================
Files 1618 1618
Lines 57152 57173 +21
Branches 5899 5907 +8
==========================================
+ Hits 46936 46939 +3
- Misses 10216 10234 +18 ☔ View full report in Codecov by Sentry. |
...ts/all-instances/instance-details/instance-general-info/instance-general-info.component.html
Outdated
Show resolved
Hide resolved
RehanY147
requested changes
Nov 13, 2024
denysbutenko
approved these changes
Nov 14, 2024
src/app/pages/virtualization/components/instance-wizard/instance-wizard.component.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
See ticket, result:
Screen.Recording.2024-11-12.at.14.35.49.mov