Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132263 / 24.10.1 / Change TrueCloud Backup form to have a Transfer setting #11014

Open
wants to merge 2 commits into
base: stable/electriceel
Choose a base branch
from

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 12, 2024

Changes:

Bandwidth Limit and Transfers fields are removed from TrueCloud Backup form. There is now a Transfer Setting dropdown instead.

Downstream

Affects Reasoning
Documentation Field changes in the form.

…opdown for transfer_setting""

This reverts commit 9dd7883.
@undsoft undsoft requested a review from a team as a code owner November 12, 2024 10:37
@undsoft undsoft requested review from bvasilenko and removed request for a team November 12, 2024 10:37
@bugclerk bugclerk changed the title NAS-132263: Change TrueCloud Backup form to have a Transfer setting NAS-132263 / 24.10.1 / Change TrueCloud Backup form to have a Transfer setting Nov 12, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@9dd7883). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11014   +/-   ##
=====================================================
  Coverage                      ?   79.97%           
=====================================================
  Files                         ?     1572           
  Lines                         ?    51437           
  Branches                      ?     5938           
=====================================================
  Hits                          ?    41139           
  Misses                        ?    10298           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The form works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants