Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132301 / 25.04 / Adapt changes for boot environments #11012

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

Changes:

Adapt new boot environment endpoints.

Testing:

Check Boot Environments.

@denysbutenko denysbutenko requested a review from a team as a code owner November 11, 2024 17:56
@denysbutenko denysbutenko requested review from undsoft and removed request for a team November 11, 2024 17:56
@bugclerk bugclerk changed the title NAS-132301: Adapt changes for boot environments NAS-132301 / 25.04 / Adapt changes for boot environments Nov 11, 2024
@bugclerk
Copy link
Contributor

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some UI and some middleware changes:

  • When I change scrub interval in scrub settings, old value is still shown in the dialog next time I open it until I reload the page.
  • Cloning, activating or changing keep status results in [EINVAL] result: Input should be a valid dictionary or instance of BootEnvironmentEntry
  • Date Created column shows different dates compared to old version
  • Space column can be called Used Space like used to be
  • Delete dialog is missing text prompt: "The following boot environment will be deleted. Are you sure you want to proceed" and there is no Delete button.
  • Clone form shouldn't close on errors.

@denysbutenko
Copy link
Member Author

Some UI and some middleware changes:

  • When I change scrub interval in scrub settings, old value is still shown in the dialog next time I open it until I reload the page.

Fixed

  • Cloning, activating or changing keep status results in [EINVAL] result: Input should be a valid dictionary or instance of BootEnvironmentEntry

Fixed in recent nightly middleware

  • Date Created column shows different dates compared to old version

This is possibly due to the date/time format saved in local storage. We still use the same field and table column.

  • Space column can be called Used Space like used to be

Done

  • Delete dialog is missing text prompt: "The following boot environment will be deleted. Are you sure you want to proceed" and there is no Delete button.

Fixed

  • Clone form shouldn't close on errors.

Fixed

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants