Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131231 / 25.04 / if you enter an invalid AUTH key, tailscale goes into a tight restart loop #10704

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Changes:
Now we are able to stop the app with Deploying status.

– The retry of deploying is done by docker.
Only allow stop from the UI is the option to fix this bug.

I've discussed it with @stavros-k .

Testing:
See ticket, comments, the only way for now is to allow stopping an app which is in Deploying phase.

Downstream

Affects Reasoning
Documentation We can stop app with Deploying status.

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 18, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 18, 2024 10:31
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team September 18, 2024 10:31
@bugclerk bugclerk changed the title NAS-131231: if you enter an invalid AUTH key, tailscale goes into a tight restart loop NAS-131231 / 25.04 / if you enter an invalid AUTH key, tailscale goes into a tight restart loop Sep 18, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.92%. Comparing base (f2bd4a5) to head (73295b2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ponents/installed-apps/installed-apps.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10704   +/-   ##
=======================================
  Coverage   79.92%   79.92%           
=======================================
  Files        1564     1564           
  Lines       51443    51443           
  Branches     5831     5831           
=======================================
  Hits        41118    41118           
  Misses      10325    10325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants