Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| echo "Triggering job for provider=$provider model=$model" | ||
| tfy job trigger \ | ||
| --fqn tfy-usea1-ctl-devtest:models-pricing-data:models-agent-job \ | ||
| --command "python job.py --provider $provider --model $model" |
There was a problem hiding this comment.
don't do this, it should be model and provider agnostic
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| - name: Detect changed model YAML files | ||
| id: changes | ||
| run: | | ||
| changed=$(git diff --name-only ${{ github.event.before }} ${{ github.sha }} -- 'providers/**/*.yaml' | grep -v '/default\.yaml' || true) |
There was a problem hiding this comment.
Force push causes silent skip of legitimate changes
Medium Severity
On a force push to main, github.event.before references a commit that may no longer exist in the repository (it was rewritten). Even with fetch-depth: 0, unreachable commits aren't fetched, so git diff fails. The || true swallows the error, making $changed empty, and the workflow silently skips — meaning legitimate provider changes won't trigger the updation job at all.
There was a problem hiding this comment.
pushing to main requires a pr
2 participants
Note
Medium Risk
Adds a new CI workflow that triggers an external TrueFoundry job using repository secrets; main risk is unintended job runs/costs or failures due to secret/config issues.
Overview
Adds a new GitHub Actions workflow (
.github/workflows/trigger-updation-job.yml) that runs on pushes tomainaffectingproviders/**.The job detects changes to
providers/**/*.yaml(excludingdefault.yaml) and, if any, sets up Python, installs thetruefoundryCLI, logs in usingTFY_API_KEY/TFY_HOST, and triggers a TrueFoundry job viaTFY_JOB_FQN.Written by Cursor Bugbot for commit c2909e2. This will update automatically on new commits. Configure here.