clean up functions for smoother run

[Bitseat]

No description provided.

[ngeiswei]

Regarding flatten, it outputs (Error (bc (→ B C)) IncorrectNumberOfArguments), meaning that somewhere down the line, as flatten manipulates the expression it ends up with (bc (→ B C)) and the MeTTa interpreter tries to run it. I don't know why it didn't fail before.

Do you mind attempting to figure out what is wrong?

The following much simpler expression fails for the same reason

!(flatten (: bc A))

Surely, we should be able to prevent MeTTa from running intermediary expressions, using quote or such. Or maybe modify the code so that it does not create such intermediary expression, not sure.

[ngeiswei]

Oh, this is an exploit of weak typing, charsToString is not supposed to work with strings. Although it works, I would recommend to use https://github.com/singnet/ai-dsl/blob/aaa702e9eb6c95268b085ed1906bba6f728ea76f/experimental/ai-service-composition/english-to-chinese-song/etcs-combinator-data-uncurry-xp.metta#L203

[ngeiswei]

Hmm, it is not used anywhere, maybe split-str can be removed.

[ngeiswei]

Thus this could be removed as well (I suppose).

[Bitseat]

Regarding flatten, it outputs (Error (bc (→ B C)) IncorrectNumberOfArguments), meaning that somewhere down the line, as flatten manipulates the expression it ends up with (bc (→ B C)) and the MeTTa interpreter tries to run it. I don't know why it didn't fail before.

Do you mind attempting to figure out what is wrong?

The following much simpler expression fails for the same reason

!(flatten (: bc A))

Surely, we should be able to prevent MeTTa from running intermediary expressions, using quote or such. Or maybe modify the code so that it does not create such intermediary expression, not sure.

On my end, I am getting (Error (bc (→ B C)) BadType). I am on Hyperon version 0.2.4. When I tested it on version 0.2.5, all the flatten tests failed due to the expressions returning in an unevaluated state. I can try to solve this, but on which version did you test it?

[ngeiswei]

On my end, I am getting (Error (bc (→ B C)) BadType). I am on Hyperon version 0.2.4. When I tested it on version 0.2.5, all the flatten tests failed due to the expressions returning in an unevaluated state. I can try to solve this, but on which version did you test it?

I'm running 0.2.6, but maybe it is not relevant, though I suppose it is probably indeed better if you use the latest version, just in case.

[Bitseat]

The reason for the IncorrectNumberOfArguments error is that we've defined bc as

(: bc (-> $a                            
          Nat                           
          $b                            
          $b))    

Using the same variable name bc in the test

!(assertEqual
  (flatten (: ((ModusPonens (: bc (→ B C)))
               (: ((ModusPonens (: ab (→ A B))) (: a A)) B)) C))
  (: (ModusPonens (: bc (→ B C)) (: (ModusPonens (: ab (→ A B)) (: a A)) B)) C))

causes (bc (→ B C)) to be evaluated, which results in IncorrectNumberOfArguments.