Repository navigation
Stop teaching sendable() as a liveness check - #174
Merged
Merged
Conversation
EdmondDantes
force-pushed
the
docs-body-modes-corrections
branch
from
August 19, 2026 17:56
70468e1 to
df671ae
Compare
Contributor
CoverageTotal lines: 82.26% → 82.24% (-0.03 pp)
|
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only.
README.mdshowedif (!$response->sendable()) break; // peer gone — stop earlyinside the SSE loop.sendable()reports whethersend()would park, so that line ends a stream at the first sign of backpressure and drops what it was about to write. It travelled: laravel-spawn wrapped it asSse::connected()with the same wording, and YanGusik/laravel-spawn#60 truncated a proxied body at ~100 KB with the same loop. The guard is removed rather than replaced —sseEvent()waits for room by itself, and a departed peer arrives asHttpException499.The
sendable()docblock now says what false does not mean. Thewrite()docblock said "Write data to response body buffer" without the part that matters: nothing leaves beforeend(), which is the other half of #60.The
docs/USAGE.mdsection on the three body modes is deliberately not in this PR. It would describe names that the contract in dev/PLAN.md renames in the next step, and the reporter is writing his proxy recipe against the new ones.