Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freezeV2): optimize delegate resource lock period #5255

Merged
merged 12 commits into from
Jun 2, 2023

Conversation

lxcmyf
Copy link
Contributor

@lxcmyf lxcmyf commented Jun 2, 2023

What does this PR do?
optimize delegate resource lock period
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@lxcmyf lxcmyf force-pushed the release_4.7.2 branch 4 times, most recently from d79822b to 1ea67dd Compare June 2, 2023 06:01
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #5255 (1ea67dd) into release_v4.7.2 (3c82c2a) will decrease coverage by 0.01%.
The diff coverage is 71.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                 Coverage Diff                  @@
##             release_v4.7.2    #5255      +/-   ##
====================================================
- Coverage             60.64%   60.64%   -0.01%     
- Complexity             9073     9086      +13     
====================================================
  Files                   837      837              
  Lines                 49697    49755      +58     
  Branches               5531     5541      +10     
====================================================
+ Hits                  30141    30172      +31     
- Misses                17188    17205      +17     
- Partials               2368     2378      +10     
Impacted Files Coverage Δ
.../src/main/java/org/tron/core/config/Parameter.java 75.00% <ø> (ø)
...on/core/services/http/DelegateResourceServlet.java 46.66% <0.00%> (ø)
...rc/main/java/org/tron/core/utils/ProposalUtil.java 32.29% <33.33%> (-0.20%) ⬇️
...ava/org/tron/common/parameter/CommonParameter.java 57.46% <50.00%> (-0.05%) ⬇️
...va/org/tron/core/store/DynamicPropertiesStore.java 96.98% <64.70%> (-0.33%) ⬇️
.../java/org/tron/core/consensus/ProposalService.java 92.48% <66.66%> (-0.46%) ⬇️
framework/src/main/java/org/tron/core/Wallet.java 39.62% <69.56%> (+0.09%) ⬆️
...g/tron/core/actuator/DelegateResourceActuator.java 85.44% <87.50%> (+2.23%) ⬆️
...main/java/org/tron/core/utils/TransactionUtil.java 45.23% <100.00%> (+0.43%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxcmyf lxcmyf force-pushed the release_4.7.2 branch 2 times, most recently from b30fd81 to 83a3b9b Compare June 2, 2023 10:32
lxcmyf added 2 commits June 2, 2023 20:34
# Conflicts:
#	actuator/src/main/java/org/tron/core/utils/ProposalUtil.java
#	chainbase/src/main/java/org/tron/core/store/DynamicPropertiesStore.java
#	common/src/main/java/org/tron/common/parameter/CommonParameter.java
#	framework/src/main/java/org/tron/core/Wallet.java
#	framework/src/main/java/org/tron/core/consensus/ProposalService.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants