Skip to content

fix(json-rpc): fix getStorageAt on contract created by create2 #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tomatoishealthy
Copy link
Contributor

What does this PR do?

fix address generation of contract created by create2

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

halibobo1205 and others added 5 commits February 28, 2023 16:03
  1. One and only one appender may be attached to AsyncAppender.
feat(log): remove unused appender in AsyncAppender
fix(gradle): clean up the sub-project build directory
@tomatoishealthy tomatoishealthy force-pushed the hotfix/json-rpc-get-storage branch from 1de96ce to 1209f43 Compare March 14, 2023 05:51
@tomatoishealthy tomatoishealthy force-pushed the hotfix/json-rpc-get-storage branch from 1209f43 to fcf3366 Compare March 14, 2023 06:08
Copy link
Contributor

@yanghang8612 yanghang8612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomatoishealthy tomatoishealthy changed the base branch from develop to release_v4.7.2 March 17, 2023 06:47
@tomatoishealthy tomatoishealthy merged commit 74b34bc into tronprotocol:release_v4.7.2 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants