[JS] Remaining JS rules test by trolit · Pull Request #9 · trolit/patchron-test

trolit · 2022-07-31T13:49:01Z

No description provided.

patchron · 2022-07-31T14:28:29Z

+}
+
+function test2() {
+    this.helpers.doSomething().then((rules) => {


Please, stick to await asynchronous pattern in the project.

patchron · 2022-07-31T14:28:33Z

+
+let index = 0;
+
+while (index < data.length) {


It seems that length property is initialized in condition statement. Please initialize it before loop.

patchron · 2022-07-31T14:28:38Z

+
+do {
+    index++;
+} while (index < data.length);


It seems that length property is initialized in condition statement. Please initialize it before loop.

patchron · 2022-07-31T14:28:50Z

+import helpers1 from '@/helpers/index';
+import helpers2 from '@/helpers';
+
+const helpers3 = require('@/helpers/index');


Please do not reference file named index explicitly in require.

patchron · 2022-07-31T14:29:02Z

+import test1 from '@/helpers/test1.js';
+import test2 from '@/helpers/test2';
+
+const test3 = require('@/helpers/test3.js');


Please, remove extension from marked require.

patchron · 2022-07-31T14:29:07Z

@@ -0,0 +1,29 @@
+const test = false;
+
+if (test === true) {


Please, simplify marked code.

value === true, value !== false -> value
value === false, value !== true -> !value

patchron · 2022-07-31T14:29:11Z

+
+const test2 = null;
+
+if (test2 === null) {


Please, simplify marked code.

value === null/undefined -> !value
value !== null/undefined -> !!value, value

patchron · 2022-07-31T14:29:15Z

+
+const result = -1;
+
+if (result !== -1) {


Please, simplify marked code.

value !== -1 -> ~value

patchron · 2022-07-31T14:29:19Z

@@ -0,0 +1,14 @@
+const a = {
+    test1: test1,


It seems that there is redundant value assignment (assigned value has the same name as key) 🤔

patchron · 2022-07-31T14:29:23Z

+    test1: test1,
+    b: 5,
+    c: 15,
+    test15: test15


It seems that there is redundant value assignment (assigned value has the same name as key) 🤔

patchron · 2022-07-31T14:29:27Z

+    test15: test15
+};
+
+const b = { a: 15, b: b };


It seems that there is redundant value assignment (assigned value has the same name as key) 🤔

patchron · 2022-07-31T14:29:31Z

+
+const b = { a: 15, b: b };
+
+const c = { test13: test13 };


It seems that there is redundant value assignment (assigned value has the same name as key) 🤔

patchron · 2022-07-31T14:29:36Z

+
+const c = { test13: test13 };
+
+const d = { result: { test: { a: a } } };


It seems that there is redundant value assignment (assigned value has the same name as key) 🤔

patchron · 2022-07-31T14:29:40Z

+
+const d = { result: { test: { a: a } } };
+
+const e = { result: { comments: { summary: { total: total } } } };


It seems that there is redundant value assignment (assigned value has the same name as key) 🤔

patchron · 2022-07-31T14:29:44Z

pull request review completed

💬 18 comment(s) require attention.
🔨 1 commit(s)
➕ 99 additions
➖ 0 deletions
➗ 6 changed files

d

fbc4727