[JS] PositionedKeywordsRule (require) - #2
Open
trolit wants to merge 1 commit into
Open
Conversation
![patchron[bot]](https://avatars.githubusercontent.com/in/165569?s=60&v=4){kind=small}
Comment on lines
+3
to
+11
| const test2 = require('@/helpers/helper2'); | ||
|
|
||
| module.exports = (a, b) => { | ||
| const sum = a + b; | ||
|
|
||
| return sum; | ||
| }; | ||
|
|
||
| const lodash = require('lodash'); |
There was a problem hiding this comment.
Found 7 line(s) between require lines 3 and 11 but there shouldn't be any
Comment on lines
+11
to
+13
| const lodash = require('lodash'); | ||
|
|
||
| const test3 = require('@/helpers/helper3'); |
There was a problem hiding this comment.
Found 1 line(s) between require lines 11 and 13 but there shouldn't be any
| return sum; | ||
| }; | ||
|
|
||
| const lodash = require('lodash'); |
There was a problem hiding this comment.
Line 11 (packages) should appear before line 2 (other)
Expected order:
packages >> other
|
pull request review completed 💬 4 comment(s) require attention. |
trolit
force-pushed
the
main
branch
3 times, most recently
from
September 2, 2022 18:10
459394f to
d8a500d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.