Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build when dired disabled #23

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Fix build when dired disabled #23

merged 1 commit into from
Feb 18, 2024

Conversation

g-branden-robinson
Copy link
Contributor

@g-branden-robinson g-branden-robinson commented Feb 11, 2024 •
edited
Loading

  • src/def.h:
  • src/dired.c:
  • src/funmap.c:
  • src/keymap.c: Guard references to dired_jump function and its implementation behind ENABLE_DIRED preprocessor maco.

Fixes the following linker error when building with --disable-dired configuration option and those that imply it.

/usr/bin/ld: /tmp/branden/mg.E83i08.ltrans0.ltrans.o:(.data.rel.cXcJ+0x0): undefined reference to `dired_jump'
/usr/bin/ld: /tmp/branden/mg.E83i08.ltrans0.ltrans.o:(.data.rel.functnames+0x480): undefined reference to `dired_jump'
collect2: error: ld returned 1 exit status

@g-branden-robinson
Copy link
Contributor Author

You might also be interested in or amused by my own mg fork.

FYI, that branch gets force-pushed frequently.

troglobit
troglobit requested changes Feb 18, 2024
View reviewed changes
Copy link
Owner

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for those first two patches (not needed).

src/def.h Outdated Show resolved Hide resolved
src/dired.c Outdated Show resolved Hide resolved
@troglobit
Copy link
Owner

You might also be interested in or amused by my own mg fork.

Interesting! Only browsed through it quickly, but I'll probably go back and port a few things to my fork when I circle back to the next release cycle :-)

@g-branden-robinson
Fix build when dired disabled
f3da7b6 
* src/funmap.c:
* src/keymap.c: Guard references to `dired_jump` function and its
  implementation behind `ENABLE_DIRED` preprocessor maco.

Fixes linker error when building with `--disable-dired` configuration
option and those that imply it.
@troglobit troglobit merged commit 2241fc5 into troglobit:master Feb 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troglobit troglobit troglobit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-branden-robinson @troglobit