Skip to content

Add NUMERIC Type #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jul 25, 2022
Merged

Add NUMERIC Type #93

merged 20 commits into from
Jul 25, 2022
+81 −4

Conversation

HokutoMorita
Copy link
Contributor

@HokutoMorita HokutoMorita commented Jul 4, 2022 •
edited
Loading

What I did

Implementation of conversion process from String to NUMERIC

ToDo

Issue

https://github.com/primenumber-dev/n-transfer-ui/issues/9864

@HokutoMorita HokutoMorita self-assigned this Jul 4, 2022
@HokutoMorita HokutoMorita changed the title [ADD]NUMERIC対応 [Java版][ADD]NUMERIC対応 Jul 5, 2022
@HokutoMorita HokutoMorita marked this pull request as ready for review July 8, 2022 07:27
@HokutoMorita HokutoMorita requested a review from d-hrs July 8, 2022 07:27
@d-hrs d-hrs requested review from giwa and kekekenta July 8, 2022 07:29
kekekenta
kekekenta approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@kekekenta kekekenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HokutoMorita
Copy link
Contributor Author

@d-hrs
こちらご確認よろしくお願いいたします！

@HokutoMorita
Copy link
Contributor Author

@d-hrs @giwa
レビューよろしくお願いいたします！

d-hrs
d-hrs suggested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@d-hrs d-hrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this repository, please do everything in English.

src/main/java/org/embulk/output/bigquery_java/converter/BigqueryStringConverter.java Outdated
@@ -106,6 +108,11 @@ public static void convertAndSet(ObjectNode node, String name, String src, Bigqu
}
}
break;
case NUMERIC:
// BigQuery NUMERIC型のスケール最大値が9なのでデフォルト値を9にする
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 237377b

build.gradle Outdated
@@ -12,7 +12,7 @@ repositories {
}

group = "io.trocco"
version = "0.0.21"
version = "0.0.22"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.0.22"
version = "0.1.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 68bc5aa

@HokutoMorita HokutoMorita requested a review from d-hrs July 20, 2022 05:59
@HokutoMorita
Copy link
Contributor Author

@d-hrs
Please code review

@d-hrs
Copy link
Contributor

d-hrs commented Jul 22, 2022

please change title & description in English.

@HokutoMorita
Copy link
Contributor Author

@d-hrs
Please code review

@d-hrs
Copy link
Contributor

d-hrs commented Jul 22, 2022

[Java版][ADD]NUMERIC対応 #93

in English please.

@HokutoMorita HokutoMorita changed the title [Java版][ADD]NUMERIC対応 [Java Ver][ADD]NUMERIC Type Jul 22, 2022
@HokutoMorita
Copy link
Contributor Author

[Java版][ADD]NUMERIC対応 #93

in English please.

@d-hrs
Thank you for making sure
I fixed

@HokutoMorita HokutoMorita changed the title [Java Ver][ADD]NUMERIC Type Add NUMERIC Type Jul 25, 2022
@HokutoMorita
Copy link
Contributor Author

@d-hrs
Please review

@HokutoMorita HokutoMorita merged commit fbe4b9b into master Jul 25, 2022
@HokutoMorita HokutoMorita deleted the add_column_type_numeric branch July 25, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-hrs d-hrs d-hrs approved these changes

@kekekenta kekekenta kekekenta approved these changes

@giwa giwa Awaiting requested review from giwa

Assignees

@HokutoMorita HokutoMorita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HokutoMorita @d-hrs @kekekenta