-
Notifications
You must be signed in to change notification settings - Fork 17
Allow a different eltype only for the coordinates #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81032a1 to
d94896c
Compare
Collaborator
|
/run-gpu-tests |
Collaborator
|
/run-gpu-tests |
Collaborator
|
/run-gpu-tests |
svchb
added a commit
to trixi-framework/PointNeighbors.jl
that referenced
this pull request
Nov 17, 2025
Prepare release for TrixiP release trixi-framework/TrixiParticles.jl#956
Member
Author
|
/run-gpu-tests |
Collaborator
|
/run-gpu-tests |
svchb
previously approved these changes
Nov 27, 2025
…cles.jl into coordinates-eltype
svchb
previously approved these changes
Nov 27, 2025
Member
Author
|
/run-gpu-tests |
Collaborator
|
/run-gpu-tests |
LasNikas
requested changes
Dec 2, 2025
Collaborator
LasNikas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm, wondering if we want the ELTYPE and coordinates eltype info in the show box for Semidiscretization, too?
Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com>
Collaborator
|
/run-gpu-tests |
3 tasks
LasNikas
approved these changes
Dec 3, 2025
svchb
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a keyword
coordinates_eltypeto theRectangularTank,RectangularShapeandSphereShape, which defaults toFloat64.This will make the coordinates
Float64, while everything else is stillFloat32.For large numbers of particles, the particle spacing becomes very small relative to the domain size, which create larger errors in the distances between neighboring particles (relative to the particle spacing). With
Float32coordinates, these errors can easily grow to a point where they cause artifacts in the simulation.This can easily be demonstrated by running the 2D dam break and passing


min_coordinates = (1000.0, 1000.0)to theRectangularTank. WithFloat32, this yields:With this PR and
Float64coordinates:Here is a benchmark of a full dam break simulation and of just the fluid-fluid interaction kernel with 320k particles on an Nvidia RTX A4500.