Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic CI #6

Merged
merged 28 commits into from
Jul 16, 2024
Merged

Adding basic CI #6

merged 28 commits into from
Jul 16, 2024

Conversation

tristanmontoya
Copy link
Member

@tristanmontoya tristanmontoya commented Jul 10, 2024

As suggested by @sloede, I added a very basic testing workflow based on
https://github.com/trixi-framework/TrixiShallowWater.jl/tree/c1cad34a12a4e17c716601292042107925a89886 as a step towards addressing issue #3.

@tristanmontoya tristanmontoya marked this pull request as draft July 10, 2024 14:46
test/Project.toml Outdated Show resolved Hide resolved
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@tristanmontoya tristanmontoya marked this pull request as ready for review July 10, 2024 20:07
Copy link
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for going ahead!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@benegee
Copy link
Collaborator

benegee commented Jul 15, 2024

More stuff (docs, ...?) to come. But we could also do it in a separate PR.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tristanmontoya and others added 4 commits July 15, 2024 22:06
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
tristanmontoya and others added 6 commits July 15, 2024 22:07
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@benegee benegee self-requested a review July 15, 2024 21:29
Copy link
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go?

@benegee benegee dismissed ranocha’s stale review July 16, 2024 14:46

Conversation resolved.

@benegee benegee merged commit 1659683 into main Jul 16, 2024
7 checks passed
@benegee benegee deleted the tm/add_ci branch July 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants