-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Standard weak-form DG for the spherical shallow water equations in covariant form #37
Draft
tristanmontoya
wants to merge
91
commits into
main
Choose a base branch
from
tm/covariant_shallow_water
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion in Trixi.jl (cherry-picked from f45378e) Co-authored-by: Tristan Montoya <montoya.tristan@gmail.com>
…ltype() and ndims() functions for new struct
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 81.78% 85.59% +3.81%
==========================================
Files 8 14 +6
Lines 829 1340 +511
==========================================
+ Hits 678 1147 +469
- Misses 151 193 +42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends upon #31. Now we can solve the shallow water equations in covariant form with
P4estMesh
, although nearly all of the kernels called byrhs!
had to be rewritten. All the geometric terms are computed independently of the particular mesh (does not require structured grids) so it should extend to other grid types like icosahedral, etc. without too much effort.