Add tests for serial and static backend#3004
Draft
vchuravy wants to merge 3 commits into
Draft
Conversation
Follows the same pattern as test_kernelabstractions.jl: sets the backend preference, relaunches Julia so the @static dispatch in @threaded compiles with the new backend, runs a basic advection and Euler test to confirm correctness, then restores the original backend. The serial test uses exact reference values; the static (Threads.@threads) test uses rtol=0.001 to allow for non-deterministic floating-point ordering across threads. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…for static The euler example needs the out/ directory to exist before saving restart files. Threads.@threads :static allocates ~20-32KB per rhs! call (vs ~0 for Polyester @Batch), so use per-backend allocation thresholds rather than the Polyester-tuned 5000 limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # (e.g., from type instabilities) | ||
| @test_allocations(Trixi.rhs!, semi, sol, 5000) | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # Threads.@threads :static has more overhead than Polyester's @batch | ||
| @test_allocations(Trixi.rhs!, semi, sol, 50_000) | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
=======================================
Coverage 97.13% 97.13%
=======================================
Files 625 625
Lines 48514 48516 +2
=======================================
+ Hits 47122 47124 +2
Misses 1392 1392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ranocha
reviewed
May 8, 2026
Comment on lines
+89
to
+90
| - serial | ||
| - threads |
Member
There was a problem hiding this comment.
Can we find a bit more descriptive name for it, e.g., base_threads or so?
ranocha
reviewed
May 8, 2026
Member
ranocha
left a comment
ranocha
left a comment
There was a problem hiding this comment.
Thanks, that's a good idea. Since we will likely not need many tests in here, could it be an option to use a single additional CI job for both cases to reduce overhead from installing Trixi.jl etc.?
Did you make sure to include at least
- one elixir without manual threading for the ODE solver,
- one elixir with manual threading for the ODE solver,
- and one elixir with a Trixi.jl-internal time integrator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that we are adding some more backend specific behavior (as an example #3003),
we should have some smoke tests for the different backends