Skip to content

Add parabolic RHS support for StructuredMesh{2}#2862

Open
jlchan wants to merge 11 commits intomainfrom
jc/structured_mesh_entropy_correction
Open

Add parabolic RHS support for StructuredMesh{2}#2862
jlchan wants to merge 11 commits intomainfrom
jc/structured_mesh_entropy_correction

Conversation

@jlchan
Copy link
Copy Markdown
Contributor

@jlchan jlchan commented Mar 14, 2026

Non-Claude comments

  • This was generated with assistance from Claude, which pretty much created a working draft on first try.
  • The original PR was longer, so I tried to reduce the size of the PR by reusing more code.
  • Claude sometimes stalls trying to test its changes (it seems to have issues with Julia's project and testing configurations), so I checked those manually. The plot of the solution looks qualitatively good if I run
trixi_include(joinpath(examples_dir(), "structured_2d_dgsem",
                                        "elixir_navierstokes_convergence.jl"), cells_per_dimension=(8,8),
                               tspan=(0.0, 0.2))
Screenshot 2026-03-14 at 12 18 59 PM

The oscillations disappear under mesh refinement. Different numbers of elements in x and y works as well.

Summary

  • Extends the 2D parabolic solver (BR1 viscous formulation) to StructuredMesh{2} by adding it to Union type signatures in shared functions (create_cache_parabolic, transform_variables!, calc_viscous_fluxes!, calc_volume_integral!, calc_volume_integral_gradient!, apply_jacobian_parabolic!)
  • Adds src/solvers/dgsem_structured/dg_2d_parabolic.jl with StructuredMesh{2}-specific implementations: prolong2interfaces!, calc_interface_flux!, prolong2boundaries!, calc_boundary_flux!, and the top-level rhs_parabolic!
  • Adds a convergence test elixir examples/structured_2d_dgsem/elixir_navierstokes_convergence.jl on a curved periodic mesh (wavy mapping from elixir_euler_free_stream.jl) confirming order-4 L2 convergence (polydeg=3)
  • Adds a regression test in test/test_parabolic_2d.jl

Convergence results (polydeg=3, cells_per_dimension doubled from 4×4 → 8×8 → 16×16)

Variable Mean L2 EOC
rho 4.57
rho_v1 4.33
rho_v2 4.23
rho_e_total 4.87

Test plan

  • CI passes

🤖 Generated with Claude Code

Extend the 2D parabolic solver (Navier-Stokes / BR1 viscous formulation)
to work with StructuredMesh{2} by:

- Adding StructuredMesh{2} to Union types in shared functions
  (create_cache_parabolic, transform_variables!, calc_viscous_fluxes!,
  calc_volume_integral!, calc_volume_integral_gradient!,
  apply_jacobian_parabolic!) in the tree/p4est parabolic files
- Adding a new src/solvers/dgsem_structured/dg_2d_parabolic.jl with
  StructuredMesh{2}-specific implementations: prolong2interfaces!,
  calc_interface_flux!, prolong2boundaries!, calc_boundary_flux!,
  and rhs_parabolic!
- Including dg_2d_parabolic.jl from dg.jl
- Adding a convergence test elixir on a curved periodic mesh
  (examples/structured_2d_dgsem/elixir_navierstokes_convergence.jl)
  and a corresponding test in test/test_parabolic_2d.jl

The convergence test confirms order-4 convergence (polydeg=3) on the
wavy mapping from elixir_euler_free_stream.jl.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

jlchan and others added 7 commits March 14, 2026 11:19
Switch solver to default flux_lax_friedrichs and update test reference
values obtained with --check-bounds=yes to match the CI test environment.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…esh)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jlchan jlchan added the enhancement New feature or request label Mar 14, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 98.92183% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (9d6e4b4) to head (c706074).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/solvers/dgsem_structured/dg_2d_parabolic.jl 98.24% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
+ Coverage   97.04%   97.06%   +0.01%     
==========================================
  Files         605      608       +3     
  Lines       47329    47695     +366     
==========================================
+ Hits        45930    46292     +362     
- Misses       1399     1403       +4     
Flag Coverage Δ
unittests 97.06% <98.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlchan jlchan marked this pull request as ready for review March 15, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request low-priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants