(#276) Fixed dollar sign group replace in vue preprocessor #283
+197
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace#specifying_a_string_as_the_replacement
When vue code contained groupings such as
$'
or$$
, the call to"".replace()
would treat these as special replacements producing invalid code.Switching the replacement arg to a function returning the same string skips this logic.
The tests pass, and as this is only removing special functionality I would assume this is a safe change
EDIT: I've also added another commit to this PR which fixes having both a script and a script/setup tags in a SFC