Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make @vue/compiler-sfc peer dependency #183

Merged

Conversation

blake-newman
Copy link
Contributor

As Vue files are optionally supported; make @vue/compiler-sfc peer dependency.

satisfies: IanVS/prettier-plugin-sort-imports#40

As Vue files are optionally supported; make `@vue/compiler-sfc` peer
dependency.
@blake-newman
Copy link
Contributor Author

Note to the authors; since this changes this to be a peer dependency it's technically breaking so worth releasing on a major bump.

Copy link
Collaborator

@byara byara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @blake-newman 👏

@ayusharma
Copy link
Collaborator

As this is a breaking change, I would release it in the next major version.

@byara byara merged commit 11cdf38 into trivago:master Nov 24, 2022
@byara
Copy link
Collaborator

byara commented Nov 24, 2022

Released in v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants