fix: make type fields optional and add JSDoc #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byara
approved these changes
Oct 25, 2022
IanVS
added a commit
to IanVS/prettier-plugin-sort-imports
that referenced
this pull request
Oct 26, 2022
Ported from trivago/prettier-plugin-sort-imports#173 & trivago/prettier-plugin-sort-imports#180 We'll likely be deprecating many of these options in the future, but for now, we may as well expose their types and give them some nice docs. Co-authored-by: Nutthapat Pongtanyavichai <59821765+Leomotors@users.noreply.github.com>
ayusharma
approved these changes
Nov 18, 2022
|
Released in v4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last PR, I made some mistakes there about forgetting to make some options optional. Sorry for that 😅.
In addition to that, I add JSDoc because I think it is nice to have.
I also type the
importOrderParserPluginswith the appropriate type to help with checking and autocomplete.