-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update babel #147
Update babel #147
Conversation
I would prefer to use caret syntax so the end user is able to align version used in the project |
"@babel/core": "7.17.8", | ||
"@babel/generator": "7.17.7", | ||
"@babel/parser": "7.17.8", | ||
"@babel/traverse": "7.17.3", | ||
"@babel/types": "7.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jmfrancois saying that it would benefit for the project to be able to align the version using the caret
"@babel/core": "7.17.8", | |
"@babel/generator": "7.17.7", | |
"@babel/parser": "7.17.8", | |
"@babel/traverse": "7.17.3", | |
"@babel/types": "7.17.0", | |
"@babel/core": "^7.17.8", | |
"@babel/generator": "^7.17.7", | |
"@babel/parser": "^7.17.8", | |
"@babel/traverse": "^7.17.3", | |
"@babel/types": "^7.17.0", |
@jmfrancois @romainseb I agree, but there are also advantages using locked versions, especially for an OSS project (predictability at the expense of flexibility, because e.g. a Babel release can be broken and issues would be opened on this repo). So I'll let this PR as is, it's less opinionated that changing the version ranges, and it fixes the current issues. |
I really trust babel because when a babel release is broken you can be sure a lot of things will be broken. At least we are force to use resolution mecanism to align babel in most of our projects because of this little dependency . This is the only one in the middle of thousands ! |
When is this going to be merged? is this repository maintained? |
@byara and @ayusharma I see you're listed as maintainers and I was wondering if you could give an ETA on when this might be merged and released? |
|
This PR fixes #134 and #141
The embedded Babel version is outdated and does not support newer TypeScript syntaxes.
It would be great if you could publish a release when this PR is merged, it's a blocker for recent TypeScript projects. 😉