Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to group namespace specifiers #105

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Option to group namespace specifiers #105

merged 5 commits into from
Nov 11, 2021

Conversation

matt-kinton
Copy link
Contributor

@matt-kinton matt-kinton commented Nov 9, 2021

This PR adds the importOrderGroupNamespaceSpecifiers config variable. When true it groups import * as lib from 'lib' imports to the top of the group.

Closes #104

src/index.ts Outdated Show resolved Hide resolved
@ayusharma
Copy link
Collaborator

Hi @Mattinton, The build is failing. Could you please check it.

@ayusharma ayusharma requested a review from byara November 9, 2021 17:41
@matt-kinton
Copy link
Contributor Author

Hi @Mattinton, The build is failing. Could you please check it.

Sorry should have checked this before the PR. Should be passing now.

@matt-kinton
Copy link
Contributor Author

Is there a standard release schedule for PR's like this?

@ayusharma
Copy link
Collaborator

Is there a standard release schedule for PR's like this?

We will try to release the PR this week.

@byara byara changed the base branch from master to v3.2.x November 11, 2021 13:07
@byara byara merged commit f7303ba into trivago:v3.2.x Nov 11, 2021
@ayusharma
Copy link
Collaborator

Hi @Mattinton , we had merged your changes to v3.2.x branch. We will try to release it as soon as possible along with some new changes. Thank you so much for your contribution ❤️

@matt-kinton
Copy link
Contributor Author

Hi, is there any progress on a release for this?

Cheers!

@ayusharma
Copy link
Collaborator

HI @Mattinton, Thank you so much for your PR. Please respond to the notification here. #118

@matt-kinton
Copy link
Contributor Author

Hey @ayusharma, I emailed opensource@trivago.com a while ago but never got any response! Should I try again?

@ayusharma
Copy link
Collaborator

Hi @Mattinton, It seems some issue. Could you please send the details again?

@matt-kinton
Copy link
Contributor Author

Sent again, let me know if any issues :D

@ayusharma
Copy link
Collaborator

Hi @Mattinton, I still have not received the mail. I checked the mail systems and they are working fine. Could you please drop the information to ayush.sharma@trivago.com and please cc behrang.yarahmadi@trivago.com

@matt-kinton
Copy link
Contributor Author

Sent again again 😆. Hoping it goes through this time!

@ayusharma
Copy link
Collaborator

I received it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Option to sort 'import * as lib from "lib"' first
3 participants