Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow triton.code_gen.Binary to print asm. #89

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Allow triton.code_gen.Binary to print asm. #89

merged 4 commits into from
Apr 23, 2021

Conversation

daadaada
Copy link
Contributor

An example can be found in triton/python/tutorical/01-vector-add.py

print(kernel.asm('ptx'))

@ptillet
Copy link
Collaborator

ptillet commented Apr 23, 2021

Hi, a few comments:

  • Can you rename asm('ir') to asm('ttir') or something? ir makes it a bit unclear that it is the Triton-IR rather than the LLVM-IR
  • Can you leave 01-vector-add.py ?I think in general returning a handle to the binary that was executed is not what we want users to do, so I'd like to document printing asm less aggressively for now. We should probably improve the API so that one can also do _add.asm(**meta) without having to actually run the op; we could then document that in the tutorial.

@daadaada daadaada changed the title Allow triton.code_gen.Binary to print asm Allow triton.code_gen.Binary to print asm. Apr 23, 2021
@ptillet ptillet merged commit 139fb98 into triton-lang:master Apr 23, 2021
ptillet pushed a commit that referenced this pull request Jul 27, 2021
@daadaada @ptillet
[PYTHON] Allow triton.code_gen.Binary to print Triton-IR asm. (#89)
f668837
dfukalov pushed a commit to dfukalov/triton that referenced this pull request Feb 9, 2023
@rsanthanam-amd
Merge pull request triton-lang#89 from ROCmSoftwarePlatform/enable_la…
e029a13 
…yernor_bwd_pass

Enable layernorm backward pass.
pingzhuu pushed a commit to siliconflow/triton that referenced this pull request Apr 2, 2024
@daadaada @ptillet
[PYTHON] Allow triton.code_gen.Binary to print Triton-IR asm. (triton…
e357108 
…-lang#89)
oraluben pushed a commit to oraluben/triton that referenced this pull request Sep 11, 2024
@int3
Make tl.debug_barrier() a no-op on CPU (triton-lang#89)
64872bb
pawelszczerbuk pushed a commit that referenced this pull request Nov 7, 2024
@ThomasRaoux
Switch attention forward pass to use TMA (#89)
b504860 
Change our BW experimental kernel to use TMA.
This only changes the forward pass for now as this is what we are
concentrating on for perf.
gglin001 pushed a commit to gglin001/triton that referenced this pull request Nov 13, 2024
@int3 @minjang
Make tl.debug_barrier() a no-op on CPU (triton-lang#89)
ba12576
stephen-huan pushed a commit to stephen-huan/triton that referenced this pull request Dec 24, 2024
@int3 @ienkovich
Make tl.debug_barrier() a no-op on CPU (triton-lang#89)
50ab503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daadaada @ptillet