Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fix bugs in range-analysis, and let buffer-ops use the range-analysis result to decide if it's legal to convert memory-op to buffer-ops.
It fixes https://github.com/ROCm/triton-internal/issues/1180 and ROCm#871.
The highlight are following:
Range Analysis
tl.assume
. Previously, it does not consider the control flow relationship between, saytl.assume x > 0
and the location of occurrence of x.make_range(begin, end)
, previous vr is [begin, end], now is [begin, end-1]. Small change in concept incur huge change the regression test.Buffer-ops