Skip to content

[BACKEND] Applying correct filtering in membar for nvidia #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[BACKEND] Applying correct filtering in membar for nvidia #7846

wants to merge 1 commit into from

Conversation

ThomasRaoux
Copy link
Collaborator

@ThomasRaoux ThomasRaoux commented Aug 13, 2025 •
edited by lezcano
Loading

Fixes #6960

@ThomasRaoux ThomasRaoux requested a review from ptillet as a code owner August 13, 2025 15:52
@Jokeren
Copy link
Contributor

Jokeren commented Aug 13, 2025

I wonder if there should be a dedicated mlir test to catch this case?

@ThomasRaoux
Copy link
Collaborator Author

I wonder if there should be a dedicated mlir test to catch this case?

yeah not sure what would make sense, the filtering is tested already it is just that it wasn't applied and testing the full pass is a bit annoying

@ThomasRaoux
Copy link
Collaborator Author

this somehow regress perf :(

@ThomasRaoux ThomasRaoux marked this pull request as draft August 14, 2025 05:03
@lijinpei lijinpei mentioned this pull request Oct 5, 2025
Open
3 tasks
@lijinpei
Copy link
Contributor

lijinpei commented Oct 5, 2025

I have created a pr for similar purpose, while some barrier is not eliminated by this pr in my example #8374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezcano lezcano lezcano approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NVIDIA::canSkipBarSync not used in TritonGPUToLLVM stage
4 participants
@ThomasRaoux @Jokeren @lijinpei @lezcano