[Python:compiler] Replace readbytes with MMAP #6650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbell10
reviewed
Apr 30, 2025
kot-begemot-uk
force-pushed
the
mmap
branch
4 times, most recently
from
060fca0 to
51cb72e
Compare
This should be faster and much more "gentle" in terms of memory pressure on the host. Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
|
This requires a bit more thought - while the mmap datastructures should be OK for the driver load routines they fail the type checking. Additionally, it looks like it will need tests after all because the default unit tests are of little help here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be faster and much more "gentle" in terms of memory pressure on the host.
New contributor declaration
[x ] I am not making a trivial change, such as fixing a typo in a comment.
[x ] I have written a PR description following these
rules.
[ x] I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsSelect one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)