Skip to content

Release Only - Enable pypi promotion for 3.2.x release #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

atalman
Copy link
Collaborator

@atalman atalman commented Jan 15, 2025

We are ready for release 3.2.x hence enable promotion to pypi

@atalman atalman requested a review from ptillet as a code owner January 15, 2025 15:27
Copy link
Collaborator

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but fragile. Can't we do something similar to PyTorch, i.e. promote to pypi if and only if tag is  pushed. This way one does not have to make those temporary changes for every release branch?

@atalman
Copy link
Collaborator Author

atalman commented Jan 15, 2025

Hi @malfet I believe these temp changes where not really required since the secrets.PYPY_API_TOKEN is not available on pull request. I added if: false to make sure we are not releasing these binaries accidentally.

I think its a good idea to trigger release on tag push, we just need to make there are all kind of security settings in place to protect the tag, so its not pushed by mistake and make sure only few people can push it.

@atalman atalman merged commit 9641643 into triton-lang:release/3.2.x Jan 22, 2025
1 of 2 checks passed
atalman added a commit that referenced this pull request Apr 9, 2025
Publish triton release 3.3.0 to pypi
Same as: #5618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants