Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DIALECT][NFC] Move all GPU op related functions to ops.cpp #5412

Merged
merged 3 commits into from
Dec 12, 2024
Merged

[DIALECT][NFC] Move all GPU op related functions to ops.cpp #5412

merged 3 commits into from
Dec 12, 2024

Conversation

Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Dec 12, 2024

Also does the following clean ups:

  1. Remove unused functions and variables
  2. Change dyn_cast to cast to get DialectInferLayoutInterface because retEncoding should always be available when arg has an encoding.

@Jokeren Jokeren requested a review from ptillet as a code owner December 12, 2024 14:10
@Jokeren Jokeren merged commit 3563aec into main Dec 12, 2024
7 checks passed
@Jokeren Jokeren deleted the keren/move-ops branch December 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbell10 peterbell10 peterbell10 approved these changes

@ptillet ptillet Awaiting requested review from ptillet ptillet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jokeren @peterbell10