[BACKEND] Fix a special case where elements along the k dimension are repeated within each thread #5121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jokeren
changed the title
Jokeren
commented
Nov 12, 2024
| if (auto mma = dyn_cast<NvidiaMmaEncodingAttr>(dot.getParent())) { | ||
| bool legacyLoweringIsBuggy = dot.getKWidth() >= 8; | ||
| bool legacyLoweringIsBuggy = | ||
| kWidth >= 8 || (kWidth == 4 && bitwidth == 32); |
There was a problem hiding this comment.
Let's enable this path by default soon for anything other than ldmatrix
Jokeren
changed the title
lezcano
approved these changes
Nov 13, 2024
| for (size_t e = 0; e < numElemsPerVec; ++e) { | ||
| si.push_back(kRep * numElemsPerVec + tile * kWidth + e); | ||
| } | ||
| if (kIters <= repK) { |
There was a problem hiding this comment.
nb. A way to simplify this logic is to invert the LL and then look at the register that holds the value for every top-left element of every tile.
There was a problem hiding this comment.
Right. That's something I'll try out.
…o keren/large-kwidth-fix
…o keren/large-kwidth-fix
…o keren/large-kwidth-fix
lezcano
approved these changes
Nov 14, 2024
|
Could this possibly improve performance for this use-case? #4906 (comment) |
|
I'm not sure. Feel free to try it out |
|
Currently triton built from the master branch is crashing with torch.compile that's why I asked. Will def try it once this is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes: