[BACKEND] Turn off thread locality optimization based on assumptions #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot met The pattern optimizing thread locality for reductions in a loop makes assumptions that the reduction is happening on the most inner dim. This seems deeply engrained in the code so I didn't try to fix it at the moment. It's unclear to me if this code is working as expected in general as it makes assumptions on how reshape with allow_reorder=True will move data around.
ThomasRaoux
changed the title
antiagainst
approved these changes
Sep 10, 2024
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
…riton-lang#4688) The pattern optimizing thread locality for reductions in a loop makes assumptions that the reduction is happening on the most inner dim. This seems deeply engrained in the code so I didn't try to fix it at the moment. It's unclear to me if this code is working as expected in general as it makes assumptions on how reshape with allow_reorder=True will move data around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern optimizing thread locality for reductions in a loop makes assumptions that the reduction is happening on the most inner dim. This seems deeply engrained in the code so I didn't try to fix it at the moment. It's unclear to me if this code is working as expected in general as it makes assumptions on how reshape with allow_reorder=True will move data around.