Allow third-party backends to add submodules to triton.language.extra
#4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alfie-Edwards
requested review from
antiagainst,
zhanglx13 and
ptillet
as code owners
|
The tests should pass now. |
|
Tests passed but I forgot to re-run pre-commit, I've run it now. |
|
For some reason there were more pre-commit changes after the running it a second time. Looks like everything is passing pre-commit now. |
Alfie-Edwards
force-pushed
the
alfiee/third-party-libdevice
branch
from
07b17df to
304f579
Compare
|
Rebased |
Alfie-Edwards
force-pushed
the
alfiee/third-party-libdevice
branch
from
304f579 to
962620d
Compare
|
Rebased |
|
Would #4539 solve your problem? |
Yes, that solves the issue of dispatching to third-party libdevice functions 👍. With the current third-party backend mechanism, it's possible for a backend to be entirely out of tree. The only caveat is that without in-tree changes you can only get python files into |
Alfie-Edwards
changed the title
triton.language.extra
Alfie-Edwards
force-pushed
the
alfiee/third-party-libdevice
branch
from
962620d to
3ae707b
Compare
|
Sorry for the delay. Do you still want to push this? The changes seem reasonable. Could you resolve conflicts if you still need this PR |
Alfie-Edwards
force-pushed
the
alfiee/third-party-libdevice
branch
from
3ae707b to
aef71cc
Compare
Add an optional language directory to backends. The contents of the directory is added to the `triton.language.extra` namespace when the wheel is built. Change the existing `triton.language.extra.cuda` and `triton.language.extra.hip` modules to use the new mechanism.
Alfie-Edwards
force-pushed
the
alfiee/third-party-libdevice
branch
from
aef71cc to
03aa528
Compare
Hi, no worries about the delay. Yes I'm still keen to push this. I've rebased the changes onto main. |
ThomasRaoux
approved these changes
Oct 7, 2024
sfzhu93
pushed a commit
to sfzhu93/triton
that referenced
this pull request
Oct 11, 2024
…a` (triton-lang#4503) Add an optional language directory to backends. The contents of the directory is added to `triton.language.extra` when the wheel is built. Update the existing `triton.language.extra.cuda` and `triton.language.extra.hip` modules to use the new mechanism. The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `It is already tested by python/test/unit/language/test_core.py::test_math_extern`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
Luosuu
pushed a commit
to Luosuu/triton
that referenced
this pull request
Nov 13, 2024
…a` (triton-lang#4503) Add an optional language directory to backends. The contents of the directory is added to `triton.language.extra` when the wheel is built. Update the existing `triton.language.extra.cuda` and `triton.language.extra.hip` modules to use the new mechanism. The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `It is already tested by python/test/unit/language/test_core.py::test_math_extern`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
guacamoleo
pushed a commit
to guacamoleo/triton
that referenced
this pull request
Nov 14, 2024
…a` (triton-lang#4503) Add an optional language directory to backends. The contents of the directory is added to `triton.language.extra` when the wheel is built. Update the existing `triton.language.extra.cuda` and `triton.language.extra.hip` modules to use the new mechanism. The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `It is already tested by python/test/unit/language/test_core.py::test_math_extern`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
…a` (triton-lang#4503) Add an optional language directory to backends. The contents of the directory is added to `triton.language.extra` when the wheel is built. Update the existing `triton.language.extra.cuda` and `triton.language.extra.hip` modules to use the new mechanism. The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. - [x] I am not making a trivial change, such as fixing a typo in a comment. - [x] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [x] This PR does not need a test because `It is already tested by python/test/unit/language/test_core.py::test_math_extern`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional language directory to backends. The contents of the directory is added to
triton.language.extrawhen the wheel is built.Update the existing
triton.language.extra.cudaandtriton.language.extra.hipmodules to use the new mechanism.The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.
Complete the following tasks before sending your PR, and replace
[ ]with[x]to indicate you have done them.I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsIt is already tested by python/test/unit/language/test_core.py::test_math_extern.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)