[Proton] Add warning in Proton viewer about negative byte values #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRobeck
changed the title
CRobeck
force-pushed
the
proton-negative-byte-warning
branch
from
5ec6eaa to
2af8559
Compare
CRobeck
force-pushed
the
proton-negative-byte-warning
branch
from
2af8559 to
d86ef74
Compare
Jokeren
reviewed
Aug 9, 2024
third_party/proton/proton/viewer.py
Outdated
| @@ -187,6 +187,11 @@ def parse(metrics, filename, include, exclude, threshold, depth, format): | |||
| # TODO: generalize to support multiple metrics, not just the first one | |||
| gf = filter_frames(gf, include, exclude, threshold, metrics[0]) | |||
| print(gf.tree(metric_column=metrics, expand_name=True, depth=depth, render_header=False)) | |||
| if (f"bytes (inc)" in metrics): | |||
There was a problem hiding this comment.
- It could be just "bytes (inc)" right?
- No
(and). - Can you move the new code into a function? Maybe in the future we could have warnings for other metrics as well
There was a problem hiding this comment.
I didn't get what 2 was but I don't think we should remove the ( and ) around the entire if statement.
Jokeren
reviewed
Aug 9, 2024
third_party/proton/proton/viewer.py
Outdated
|
|
||
|
|
||
| def emitWarnings(gf, metrics): | ||
| if ("bytes (inc)" in metrics): |
There was a problem hiding this comment.
Why cannot we make it if "bytes (inc)" in metrics:?
Jokeren
reviewed
Aug 9, 2024
Jokeren
reviewed
Aug 9, 2024
CRobeck
force-pushed
the
proton-negative-byte-warning
branch
from
85525cf to
2336fb6
Compare
Jokeren
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.