Update docs in accordance with the new auto-complete-config behavior #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishung5
previously approved these changes
Jul 12, 2022
nv-kmcgill53
requested changes
Jul 12, 2022
Co-authored-by: nv-kmcgill53 <101670481+nv-kmcgill53@users.noreply.github.com>
tanmayv25
force-pushed
the
tanmayv-autodoc
branch
from
0ce13ab to
8152927
Compare
nv-kmcgill53
requested changes
Jul 13, 2022
README.md
Outdated
| [here](https://github.com/triton-inference-server/server/blob/main/docs/model_configuration.md#auto-generated-model-configuration). | ||
|
|
||
| However, in Graphdef format, models do not carry sufficient metadata and hence | ||
| Triton can not generate model configuration for them. As a result, config.pbtxt |
Tabrizian
reviewed
Jul 13, 2022
Tabrizian
reviewed
Jul 13, 2022
Tabrizian
previously approved these changes
Jul 13, 2022
nv-kmcgill53
previously approved these changes
Jul 13, 2022
krishung5
reviewed
Jul 13, 2022
README.md
Outdated
| the [`ragged_batching`](https://github.com/triton-inference-server/server/blob/main/docs/ragged_batching.md#batch-input) and | ||
| [`sequence_batching`](https://github.com/triton-inference-server/server/blob/main/docs/model_configuration.md#sequence-batcher) | ||
| fields. There is not enough information in the model for the backend to be able to autocomplete these. | ||
| Addditionally, the backend cannot auto complete configuration for scalar tensors. |
krishung5
approved these changes
Jul 13, 2022
mc-nv
pushed a commit
that referenced
this pull request
Jul 14, 2022
…73) * Update docs in accordance with the new auto-complete-config behavior * Update README.md Co-authored-by: nv-kmcgill53 <101670481+nv-kmcgill53@users.noreply.github.com> * Fix ups * Fix * Address review comments * Address review comments * Fix typo Co-authored-by: nv-kmcgill53 <101670481+nv-kmcgill53@users.noreply.github.com>
mc-nv
added a commit
that referenced
this pull request
Jul 14, 2022
…73) (#74) * Update docs in accordance with the new auto-complete-config behavior * Update README.md Co-authored-by: nv-kmcgill53 <101670481+nv-kmcgill53@users.noreply.github.com> * Fix ups * Fix * Address review comments * Address review comments * Fix typo Co-authored-by: nv-kmcgill53 <101670481+nv-kmcgill53@users.noreply.github.com> Co-authored-by: Tanmay Verma <tanmay2592@gmail.com> Co-authored-by: nv-kmcgill53 <101670481+nv-kmcgill53@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.