Skip to content

Conversation

Tabrizian
Copy link
Member

No description provided.

@Tabrizian Tabrizian requested review from tanmayv25 and jbkyang-nvi and removed request for tanmayv25 June 23, 2022 15:16
@tanmayv25
Copy link
Contributor

Also, you should wait for your upstream MRs to be merged and frozen before merging this and the server PRs.

@Tabrizian
Copy link
Member Author

Tabrizian commented Jun 24, 2022

I think we should probably wait on merging these PRs until the TF container is frozen and this PR can directly go to the 22.07 branch.

@tanmayv25
Copy link
Contributor

Exactly!

@Tabrizian Tabrizian requested a review from tanmayv25 June 27, 2022 15:35
@Tabrizian Tabrizian requested a review from tanmayv25 June 29, 2022 14:37
Copy link
Contributor

@tanmayv25 tanmayv25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not approving to avoid accidental merge.

@tanmayv25 tanmayv25 self-requested a review June 29, 2022 22:29
tanmayv25
tanmayv25 previously approved these changes Jul 11, 2022
@mc-nv mc-nv changed the base branch from main to r22.07 July 11, 2022 23:47
@mc-nv mc-nv dismissed tanmayv25’s stale review July 11, 2022 23:47

The base branch was changed.

@mc-nv mc-nv merged commit ded0f08 into r22.07 Jul 12, 2022
@Tabrizian Tabrizian deleted the imant-tf-params branch July 12, 2022 02:59
mc-nv pushed a commit that referenced this pull request Aug 2, 2022
* Add support for init operations

* Add docs

* Review edit

* Review edit

* Update src/tensorflow_backend_tf.h

Co-authored-by: Tanmay Verma <tanmay2592@gmail.com>
mc-nv pushed a commit that referenced this pull request Aug 2, 2022
* Add support for init operations

* Add docs

* Review edit

* Review edit

* Update src/tensorflow_backend_tf.h

Co-authored-by: Tanmay Verma <tanmay2592@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants