Skip to content

Commit

Permalink
Review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
fpetrini15 committed Sep 5, 2024
1 parent bcc140d commit 27b7fef
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,6 @@ endif() # TRITON_ENABLE_GPU
configure_file(src/libtriton_tensorflow.ldscript libtriton_tensorflow.ldscript COPYONLY)

if (${TRITON_TENSORFLOW_DOCKER_BUILD})
if (CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "aarch64")
if(${RHEL_BUILD})
set(LIBS_ARCH "sbsa")
else()
set(LIBS_ARCH "aarch64")
endif()
else()
set(LIBS_ARCH "x86_64")
endif()

add_custom_command(
OUTPUT
${TRITON_TENSORFLOW_CC_LIBNAME}.${TRITON_TENSORFLOW_VERSION}
Expand All @@ -159,7 +149,7 @@ if (${TRITON_TENSORFLOW_DOCKER_BUILD})
COMMAND docker stop tensorflow_backend_deps || echo "error ignored..." || true
COMMAND docker rm tensorflow_backend_deps || echo "error ignored..." || true
COMMAND if [ "${TRITON_TENSORFLOW_INSTALL_EXTRA_DEPS}" = "ON" ] \; then mkdir tf_backend_deps && docker run -it -d --name tensorflow_backend_deps ${TRITON_TENSORFLOW_DOCKER_IMAGE} \; fi \;
COMMAND if [ "${TRITON_TENSORFLOW_INSTALL_EXTRA_DEPS}" = "ON" ] \; then docker exec tensorflow_backend_deps sh -c "tar -cf - $<IF:$<BOOL:${RHEL_BUILD}>,/usr/local/cuda/targets/${LIBS_ARCH}-linux/lib/,/usr/lib/${LIBS_ARCH}-linux-gnu/>libnccl.so*" | tar --strip-components=3 -xf - -C ./tf_backend_deps \; fi
COMMAND if [ "${TRITON_TENSORFLOW_INSTALL_EXTRA_DEPS}" = "ON" ] \; then docker exec tensorflow_backend_deps sh -c "find $<IF:$<BOOL:${RHEL_BUILD}>,/usr/local/cuda/targets/*-linux/lib/,/usr/lib/*-linux-gnu/>libnccl.so*" | xargs -I {} docker cp tensorflow_backend_deps:{} ./tf_backend_deps \; fi
COMMAND if [ "${TRITON_TENSORFLOW_INSTALL_EXTRA_DEPS}" = "ON" ] \; then docker stop tensorflow_backend_deps && docker rm tensorflow_backend_deps \; fi \;

COMMENT "Extracting ${TRITON_TENSORFLOW_CC_LIBNAME}.${TRITON_TENSORFLOW_VERSION} and ${TRITON_TENSORFLOW_FW_LIBNAME}.${TRITON_TENSORFLOW_VERSION} from ${TRITON_TENSORFLOW_DOCKER_IMAGE}"
Expand Down

0 comments on commit 27b7fef

Please sign in to comment.