Skip to content

test: Add L0_backend_onnxruntime test for enabling bfloat16 dtype in ONNXRuntime backend#8660

Merged
yinggeh merged 19 commits into
mainfrom
yinggeh/tgh-26-onnx-backend-does-not-support-bfloat16-inputs
Mar 5, 2026
Merged

test: Add L0_backend_onnxruntime test for enabling bfloat16 dtype in ONNXRuntime backend#8660
yinggeh merged 19 commits into
mainfrom
yinggeh/tgh-26-onnx-backend-does-not-support-bfloat16-inputs

Conversation

@yinggeh
Copy link
Copy Markdown
Contributor

@yinggeh yinggeh commented Feb 14, 2026

What does the PR do?

Add L0_backend_onnxruntime test for enabling bfloat16 dtype in ONNXRuntime backend

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

triton-inference-server/onnxruntime_backend#335

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@yinggeh yinggeh self-assigned this Feb 14, 2026
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Feb 14, 2026
@yinggeh yinggeh changed the title test: Add L0_backend_onnxruntime tests for enabling bfloat16 datatype in ONNXRuntime backend test: Add L0_backend_onnxruntime tests for enabling bfloat16 dtype in ONNXRuntime backend Feb 14, 2026
@yinggeh yinggeh changed the title test: Add L0_backend_onnxruntime tests for enabling bfloat16 dtype in ONNXRuntime backend test: Add L0_backend_onnxruntime test for enabling bfloat16 dtype in ONNXRuntime backend Feb 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds comprehensive test coverage for bfloat16 (BF16) data type support in the ONNXRuntime backend. The tests verify that the backend can properly handle BF16 tensors for inference operations through both HTTP and gRPC protocols.

Changes:

  • Added a new test script that validates bfloat16 support in the ONNXRuntime backend
  • Created a test model configuration and ONNX model for bfloat16 addition operations
  • Implemented comprehensive Python test cases covering multiple edge cases for BF16 arithmetic

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
qa/L0_backend_onnxruntime/test.sh Main test script that starts the Triton server and executes bfloat16 tests for both HTTP and gRPC protocols
qa/L0_backend_onnxruntime/bfloat16_test.py Python test implementation with comprehensive BF16 test cases including zeros, negatives, large/small values, cancellation, and identical inputs
qa/L0_backend_onnxruntime/models/add_bf16/config.pbtxt Model configuration defining BF16 input/output tensors for a simple addition operation
qa/L0_backend_onnxruntime/models/add_bf16/1/model.onnx Binary ONNX model file implementing BF16 addition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

whoisj
whoisj previously approved these changes Feb 17, 2026
Copy link
Copy Markdown
Contributor

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved w/ question.

Comment thread qa/L0_backend_onnxruntime/models/add_bf16/1/model.onnx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread qa/L0_backend_python/python_test.py Outdated
Comment thread qa/L0_backend_onnxruntime/bfloat16_test.py Outdated
Comment thread qa/common/gen_qa_model_repository Outdated
Comment thread qa/common/gen_qa_model_repository Outdated
Comment thread qa/common/gen_qa_model_repository Outdated
Comment thread qa/L0_backend_onnxruntime/bfloat16_test.py Fixed
Comment thread qa/L0_backend_onnxruntime/bfloat16_test.py Fixed
Comment thread qa/L0_backend_onnxruntime/bfloat16_test.py Fixed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread qa/L0_backend_onnxruntime/test.sh
Comment thread qa/L0_backend_onnxruntime/test.py Outdated
Comment thread qa/L0_backend_onnxruntime/gen_add_bf16_onnx_model.py Outdated
Comment thread qa/L0_backend_onnxruntime/test.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread qa/L0_backend_onnxruntime/test.sh Outdated
Comment thread qa/L0_backend_onnxruntime/test.sh
yinggeh added 2 commits March 4, 2026 18:20
…nputs' of github.com:triton-inference-server/server into yinggeh/tgh-26-onnx-backend-does-not-support-bfloat16-inputs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread qa/L0_backend_onnxruntime/test.sh Outdated
Comment thread qa/L0_backend_onnxruntime/test.sh
@yinggeh yinggeh requested a review from mc-nv March 5, 2026 18:24
@yinggeh yinggeh merged commit 952a9fb into main Mar 5, 2026
3 checks passed
@yinggeh yinggeh deleted the yinggeh/tgh-26-onnx-backend-does-not-support-bfloat16-inputs branch March 5, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

5 participants