Skip to content

fix: OpenAI and vLLM related tests #8397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2025
Merged

fix: OpenAI and vLLM related tests #8397

merged 3 commits into from
Sep 23, 2025
+4 −5

Conversation

@yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Sep 19, 2025 •
edited
Loading

  1. VLLM sets new config enable_log_requests: false by default.
    See Deprecate --disable-log-requests and replace with --enable-log-requests vllm-project/vllm#21739
  2. Update OpenAI version

@yinggeh yinggeh self-assigned this Sep 19, 2025
@yinggeh yinggeh added the PR: ci Changes to our CI configuration files and scripts label Sep 19, 2025
whoisj
whoisj approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@yinggeh please add a proper description to the PR before merging.

@mc-nv mc-nv merged commit 5072858 into r25.09 Sep 23, 2025
3 checks passed
@mc-nv mc-nv deleted the yinggeh/tri-29-2509-fix-l0_openai branch September 23, 2025 22:06
yinggeh added a commit that referenced this pull request Sep 24, 2025
@yinggeh
fix: OpenAI and vLLM related tests (#8397)
c861190
mc-nv pushed a commit that referenced this pull request Oct 6, 2025
@yinggeh @mc-nv
fix: OpenAI and vLLM related tests (#8397)
0b23c18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whoisj whoisj whoisj approved these changes

@dmitry-tokarev-nv dmitry-tokarev-nv Awaiting requested review from dmitry-tokarev-nv

Assignees

@yinggeh yinggeh

Labels

PR: ci Changes to our CI configuration files and scripts

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yinggeh @whoisj @mc-nv