Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Split L0_nomodel_perf into 2 test to ensure better debug-ability and resource util for PA #7705

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

indrajit96
Copy link
Contributor

What does the PR do?

Split L0_perf_nomodel into 2 test to better debug and run PA for custom backend.
Currently a single test gets, split into 2
Other fixes as suggested by ops team and tools team

  1. Remove tee utility
  2. Toggle PA args

This is a PR to discuss around PA args and above fixes

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

NA

Where should the reviewer start?

L0_perf_nomodel_new

Test plan:

None

Caveats:

Altering PA values alters the measurements greatly

Background

Kibana dashboard
https://gpuwa.nvidia.com/kibana/app/dashboards#/view/e18ad380-79e8-11ef-9f55-436af67f73cb?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-90d,to:now))

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant