Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add tensorrtllm_backend into doc generation #7563

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Aug 22, 2024

What does the PR do?

Add tensorrtllm_backend into doc generation.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

GitLab MR !1264

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 17763728

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@krishung5 krishung5 added the PR: docs Documentation only changes label Aug 22, 2024
Copy link
Contributor

@indrajit96 indrajit96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for adding perf_analyzer in cleanup flow

@@ -393,6 +393,12 @@ def main():
if "python_backend" in repo_tags:
clone_from_github("python_backend", repo_tags["python_backend"], github_org)

# Usage generate_docs.py --repo-tag=tensorrtllm_backend:main
if "tensorrtllm_backend" in repo_tags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick heads up, I think @statiraju is refactoring this section and will get rid of annoying if statements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Confirmed that we can merge this one for now, and Suman will add his changes on top of this.

@krishung5 krishung5 merged commit 187a4a3 into main Aug 23, 2024
3 checks passed
@krishung5 krishung5 deleted the krish-trtllm-html branch August 23, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: docs Documentation only changes
Development

Successfully merging this pull request may close these issues.

3 participants