-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Load new model version should not reload loaded existing model version(s) #7527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
kthui
force-pushed
the
jacky-load-new-model-version
branch
from
August 14, 2024 19:47
aabe4ca
to
b17c984
Compare
20 tasks
GuanLuo
previously approved these changes
Aug 16, 2024
rmccorm4
reviewed
Aug 20, 2024
rmccorm4
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking for this release, but curious about this comment: https://github.com/triton-inference-server/server/pull/7527/files#r1722556601
rmccorm4
reviewed
Aug 20, 2024
GuanLuo
approved these changes
Aug 20, 2024
rmccorm4
approved these changes
Aug 20, 2024
kthui
added a commit
that referenced
this pull request
Aug 20, 2024
mc-nv
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add the following tests on model version reload:
model_directory/common_dependency.py
, then all loaded version(s) should be reloaded on the next load request.Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/core#388
Where should the reviewer start?
Start with the core PR.
Test plan:
The PR adds the test, see the Test plan on the core PR.
Caveats:
N/A
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A