Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncIO HTTP compression test #6975

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add AsyncIO HTTP compression test #6975

merged 2 commits into from
Mar 13, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Mar 12, 2024

Verifies the Python AsyncIO HTTP client can handle data compression, plus some refactoring.

Original request and response compression algorithms:

request response request != response is original test case
- -
- deflate
deflate -
deflate deflate
- gzip
gzip -
gzip gzip
deflate gzip
gzip deflate

closes: #6887

@kthui kthui marked this pull request as ready for review March 12, 2024 02:23
@fpetrini15
Copy link
Contributor

fpetrini15 commented Mar 12, 2024

Really great work condensing the tests Jacky; it's much cleaner now! Also the table in the description was very slick 🚀.

Just one minor, optional comment.

rmccorm4
rmccorm4 previously approved these changes Mar 12, 2024
Copy link
Collaborator

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup Jacky! 🚀

Also big fan of the table in the description to summarize the changes!

Copy link
Contributor

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@kthui kthui merged commit 55b13f6 into main Mar 13, 2024
3 checks passed
@kthui kthui deleted the jacky-aio-http-compress branch March 13, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Async HTTP Python Client not working properly
3 participants