Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main post-23.06 release #5995

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Update main post-23.06 release #5995

merged 5 commits into from
Jun 30, 2023

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Jun 27, 2023

No description provided.

dyastremsky
dyastremsky reviewed Jun 27, 2023
View reviewed changes
build.py Outdated Show resolved Hide resolved
dyastremsky
dyastremsky requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me aside from needing to revert the changes to the else block in build.py's dockerfile_prepare_container_linux function.

Tabrizian
Tabrizian previously approved these changes Jun 27, 2023
View reviewed changes
dyastremsky
dyastremsky previously approved these changes Jun 27, 2023
View reviewed changes
@mc-nv mc-nv dismissed stale reviews from dyastremsky and Tabrizian via da676cc June 28, 2023 16:14
@mc-nv mc-nv requested a review from Tabrizian June 28, 2023 23:19
@mc-nv mc-nv merged commit 3e6ef8d into main Jun 30, 2023
@mc-nv mc-nv deleted the mchornyi-main branch June 30, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrizian Tabrizian Tabrizian approved these changes

@dyastremsky dyastremsky dyastremsky left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mc-nv @Tabrizian @dyastremsky @jbkyang-nvi