Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ensemble check in requiring multiple versions of the same model case #595

Merged
merged 4 commits into from
Aug 29, 2019
Merged

Fix ensemble check in requiring multiple versions of the same model case #595

merged 4 commits into from
Aug 29, 2019

Conversation

GuanLuo
Copy link
Contributor

@GuanLuo GuanLuo commented Aug 28, 2019

No description provided.

deadeyegoodwin
deadeyegoodwin previously approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@deadeyegoodwin deadeyegoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a CI test for this?

@GuanLuo
Copy link
Contributor Author

GuanLuo commented Aug 28, 2019

No, I just tested it locally, will add the test to L0_model_config.

@deadeyegoodwin deadeyegoodwin merged commit 1dacbaa into master Aug 29, 2019
@deadeyegoodwin deadeyegoodwin deleted the gluo-mrmFix branch August 29, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deadeyegoodwin deadeyegoodwin deadeyegoodwin approved these changes

@CoderHam CoderHam Awaiting requested review from CoderHam

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25

@dzier dzier Awaiting requested review from dzier

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuanLuo @deadeyegoodwin