clients:CMake:Hide symbols that are not TRTIS API #589
Conversation
src/clients/c++/CMakeLists.txt
Outdated
| @@ -40,7 +40,7 @@ add_library( | |||
| $<TARGET_OBJECTS:proto-library> | |||
| $<TARGET_OBJECTS:grpc-library> | |||
| ) | |||
|
|
|||
| set_target_properties(request PROPERTIES LINK_FLAGS "-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/EXPORT_SYMBOLS") | |||
There was a problem hiding this comment.
Can you follow the formatting convention from here: https://github.com/NVIDIA/tensorrt-inference-server/blob/master/src/servers/CMakeLists.txt#L223
Name the version script as librequest.ldscript and use configure_file to copy it to the build area: https://github.com/NVIDIA/tensorrt-inference-server/blob/master/src/servers/CMakeLists.txt#L209
Use 2 set_target_properties, one for LINK_FLAGS and one for LINK_DEPENDS.
src/clients/c++/EXPORT_SYMBOLS
Outdated
| { | ||
| global: | ||
| extern "C++" { | ||
| nvidia::inferenceserver* |
There was a problem hiding this comment.
Should be able to use nvidia::inferenceserver::client*
There was a problem hiding this comment.
I actually started with client*, but in the simple_client.cc (and my internal project repo), there is this call: ni::ServerStatus server_status
status_ctx->GetServerStatus(&server_status); , these will be undefined.
The server_status is defined in core/server_status.proto, seems like a server-only file?
request.h includes server_status.pb.h, should this server_status.pb.h be part of client headers as well?
There was a problem hiding this comment.
I see... you can just keep it like it is...
gRPC symbols were visible and caused crash on client application which is using different version of gRPC Signed-off-by: Wenjia Zhou <wenjiaz@nvidia.com>
fix style
Airie
force-pushed
the
cmake_hide_grpc_symbol
branch
from
2fb23eb
to
6dd8e00
Compare
gRPC symbols were visible and caused crash on
client application which is using different
version of gRPC
Signed-off-by: Wenjia Zhou wenjiaz@nvidia.com