Python Client API support for shared memory #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderHam
force-pushed
the
hemantj-sharedMemory-python
branch
6 times, most recently
from
9a4f7ba
to
9b909f6
Compare
CoderHam
force-pushed
the
hemantj-sharedMemory-python
branch
from
232d66a
to
b46eed2
Compare
deadeyegoodwin
suggested changes
Aug 26, 2019
src/clients/python/build_wheel.sh
Outdated
| else | ||
| cp Release/crequest.dll \ | ||
| "${WHLDIR}/tensorrtserver/api/." | ||
| cp ../c++/Release/request.dll \ | ||
| "${WHLDIR}/tensorrtserver/api/." | ||
| cp Release/cshmwrap.dll \ |
There was a problem hiding this comment.
Shared memory won't work on Windows (at least not with the api you are using). Need to have functions return error on windows platform
CoderHam
force-pushed
the
hemantj-sharedMemory-python
branch
3 times, most recently
from
5a61f1a
to
4073d99
Compare
CoderHam
force-pushed
the
hemantj-sharedMemory-python
branch
2 times, most recently
from
1105401
to
586aada
Compare
deadeyegoodwin
suggested changes
Aug 28, 2019
CoderHam
force-pushed
the
hemantj-sharedMemory-python
branch
2 times, most recently
from
1d7ad0a
to
4fc0e35
Compare
deadeyegoodwin
suggested changes
Aug 29, 2019
| @@ -832,51 +988,61 @@ def _prepare_request(self, inputs, outputs, | |||
| c_void_p(_crequest_infer_ctx_input_new(byref(input), self._ctx, input_name))) | |||
|
|
|||
| # Set the input shape | |||
| if len(input_values) > 0: | |||
| shape_value = np.asarray(input_values[0].shape, dtype=np.int64) | |||
| if isinstance(input_values, (list, tuple)): | |||
There was a problem hiding this comment.
I'm a little confused about how you've changed this logic... we can discuss.
There was a problem hiding this comment.
Since the input_values can be a list/tuple of np.arrays or a single c_void_p representing the input data values in shared memory, this check is needed. We should only get the shape from the input data if input_values is a list i.e. does not use shared memory.
CoderHam
force-pushed
the
hemantj-sharedMemory-python
branch
from
8f6cdd2
to
c866d9c
Compare
CoderHam
force-pushed
the
hemantj-sharedMemory-python
branch
from
c866d9c
to
7a41f1a
Compare
- avoid extra mmap while setting input - avoid extra memcpy for reading output
…gion per input with libchm
deadeyegoodwin
suggested changes
Aug 29, 2019
deadeyegoodwin
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using the shared memory functionality via the Python client API