Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeql run frequency #5538

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Update codeql run frequency #5538

merged 1 commit into from
Mar 22, 2023

Conversation

dyastremsky
Copy link
Contributor

Increase codeql static analysis run frequency. Run daily on Sunday-Friday, 6pm PST. (Interpreted in UTC: 1am Monday-Sunday).

@rmccorm4
Copy link
Collaborator

Can you explain the rationale? Are there any costs with running more frequently? Too many spam alerts? And why cron style over per pull request like before?

@dyastremsky
Copy link
Contributor Author

Can you explain the rationale? Are there any costs with running more frequently? Too many spam alerts? And why cron style over per pull request like before?

Mostly for consistency. I was looking at GitHub's template that specifies doing it 5x per week and updated the rest to do something similar for our workdays. Reviewing codesql's documentation, it looks you're right that scheduled jobs are in addition to the events.

Scanning code on a schedule informs you about the latest vulnerabilities and errors that GitHub, security researchers, and the community discover, even when developers aren't actively maintaining the repository.

This costs us nothing as public repositories get unlimited minutes of GitHub Actions for free. We wouldn't get more alerts, the alerts would just be refreshed more often. However, this may be more than we need. If that's the case, then I'd still want to be consistent across all repos. If you'd prefer to keep a weekly job, let me know... I may put you down as a reviewer to update the already-merged PRs, if that's okay with you.

@rmccorm4
Copy link
Collaborator

I'm happy with making them more frequent, just wanted to understand the changes compared to what we had before. Thanks for explaining 🙂

@dyastremsky dyastremsky merged commit bf06d4d into main Mar 22, 2023
@dyastremsky dyastremsky deleted the dyas-codeql-cron branch March 22, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants