Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in http server #5521

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Fix memory leak in http server #5521

merged 2 commits into from
Mar 20, 2023

Conversation

Tabrizian
Copy link
Member

No description provided.

@Tabrizian Tabrizian requested review from GuanLuo and mc-nv March 17, 2023 18:40
GuanLuo
GuanLuo previously approved these changes Mar 17, 2023
View reviewed changes
@Tabrizian Tabrizian requested a review from GuanLuo March 20, 2023 03:20
GuanLuo
GuanLuo approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@GuanLuo GuanLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not preferred to try-and-cast the parameter until the operation success. Should look into exposing the rapid-json type method in triton_json.h and use that for checking type of the parameter value

@Tabrizian
Copy link
Member Author

@GuanLuo will address this in a follow up PR.

@Tabrizian Tabrizian merged commit ed554d8 into main Mar 20, 2023
@Tabrizian Tabrizian deleted the imant-fix-leak branch March 20, 2023 22:51
@Tabrizian Tabrizian restored the imant-fix-leak branch March 20, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuanLuo GuanLuo GuanLuo approved these changes

@dyastremsky dyastremsky dyastremsky approved these changes

@mc-nv mc-nv Awaiting requested review from mc-nv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tabrizian @GuanLuo @dyastremsky